server: Reject outbound conns to non-full nodes. #1252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
server_reject_outbound_peers_without_desired_services
branch
from
878874d
to
017c2b2
Compare
davecgh
force-pushed
the
server_reject_outbound_peers_without_desired_services
branch
from
017c2b2
to
dbc42cd
Compare
alexlyp
approved these changes
Jun 4, 2018
davecgh
force-pushed
the
server_reject_outbound_peers_without_desired_services
branch
from
dbc42cd
to
fe73bee
Compare
jrick
reviewed
Jun 4, 2018
server.go
Outdated
| wantServices := wire.SFNodeNetwork | ||
| if !sp.Inbound() && !hasServices(msg.Services, wantServices) { | ||
| srvrLog.Debugf("Rejecting peer %s with services %v due to not "+ | ||
| "providing desired services %v", msg.Services, wantServices) |
There was a problem hiding this comment.
We could improve this by masking everything off except the missing services: wantServices&^msg.Services
There was a problem hiding this comment.
Doesn't really matter for dcrd's case as it only needs a single service flag, so it would be the same result either way, but that could change in the future.
There was a problem hiding this comment.
I agree that it currently is the same, but I think it's a good idea, because I would expect there to be pruned nodes in the future with a new service bit, in which case it would matter.
davecgh
force-pushed
the
server_reject_outbound_peers_without_desired_services
branch
from
fe73bee
to
7f2e71b
Compare
This modifies the server connection code to reject outbound peers that do not offer full node services.
davecgh
force-pushed
the
server_reject_outbound_peers_without_desired_services
branch
from
7f2e71b
to
166c71e
Compare
jrick
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #1251.
This modifies the server connection code to reject outbound peers that do not offer full node services.