txscript: Cleanup and add tests for rshift opcode. #1289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
txscript_cleanup_oprshift
branch
from
21283fe
to
f63eee3
Compare
dnldd
approved these changes
Jun 13, 2018
jrick
approved these changes
Jun 13, 2018
This cleans up the code for handling the right shift opcode to explicitly call out its semantics which are likely not otherwise obvious as well as improve its readability. It also adds several tests to the reference script tests which exercise the semantics of the right shift opcode including both positive and negative tests.
davecgh
force-pushed
the
txscript_cleanup_oprshift
branch
from
f63eee3
to
0ee1468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the code for handling the right shift opcode to explicitly call out its semantics which are likely not otherwise obvious as well as improve its readability.
It also adds several tests to the reference script tests which exercise the semantics of the right shift opcode including both positive and negative tests.