server: Always reply to getheaders with headers #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts a change made in 4f6ed9a which resulted in a headers response to not be created for a getheaders request if there were no more discovered headers. This was a deviation from the previous behavior of queueing a headers message with an empty vector of headers. This was a protocol change without a protocol bump, so the behavior must be reverted. I also cross referenced the Bitcoin Core source code and, just like the now-restored behavior, headers messages were always sent even when no new headers were discovered. I don't see any reason why Decred should deviate from this behavior.
davecgh
approved these changes
Jun 13, 2018
cfromknecht
added a commit
to cfromknecht/btcd
that referenced
this pull request
Aug 1, 2018
anchaj
pushed a commit
to phoreproject/btcd
that referenced
this pull request
Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts a change made in 4f6ed9a
which resulted in a headers response to not be created for a
getheaders request if there were no more discovered headers. This was
a deviation from the previous behavior of queueing a headers message
with an empty vector of headers.
This was a protocol change without a protocol bump, so the behavior
must be reverted.
I also cross referenced the Bitcoin Core source code and, just like
the now-restored behavior, headers messages were always sent even when
no new headers were discovered. I don't see any reason why Decred
should deviate from this behavior.