multi: add amount field to TransactionInput #1297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
requested changes
Jun 18, 2018
rpcserver.go
Outdated
| prevOut := wire.NewOutPoint(txHash, input.Vout, input.Tree) | ||
| txIn := wire.NewTxIn(prevOut, []byte{}) | ||
| txIn := wire.NewTxIn(prevOut, int64(amt.ToUnit(dcrutil.AmountAtom)), []byte{}) |
There was a problem hiding this comment.
This should be just a type conversion from dcrutil.Amount to int64.
dnldd
force-pushed
the
specify_outs
branch
4 times, most recently
from
e1c4191
to
10e71db
Compare
dnldd
changed the title
jrick
approved these changes
Jun 21, 2018
davecgh
requested changes
Jun 21, 2018
dnldd
force-pushed
the
specify_outs
branch
2 times, most recently
from
d801221
to
6bce7e4
Compare
davecgh
requested changes
Jun 21, 2018
docs/json_rpc_api.md
Outdated
| @@ -214,10 +214,10 @@ the method name for further details such as parameter and return information. | |||
| | | | | |||
| |---|---| | |||
| |Method|createrawtransaction| | |||
| |Parameters|1. `transaction inputs`: `(JSON array, required)` json array of json objects.<br />`hash`: `(string, required)` the hash of the input.</br> `vout`: (numeric, required) the specific output of the input transaction to redeem transaction.<br /><br />`[{"txid": "hash", "vout": n}, ...]`<br /><br />2. `addresses and amounts`: `(JSON object, required)` - json object with addresses as keys and amounts as values.</br>`address`: `(numeric, required)` the address to send to as the key and the amount in DCR as the value.<br /><br />`{"address": n.nnn, ...}`| | |||
| |Parameters|1. `transaction inputs`: `(JSON array, required)` json array of json objects.</br> `amount`: `(numeric)` the previous output amount.<br />`hash`: `(string, required)` the hash of the input.</br> `vout`: (numeric, required) the specific output of the input transaction to redeem transaction.<br /><br />`[{"amount":n, "txid": "hash", "vout": n}, ...]`<br /><br />2. `addresses and amounts`: `(JSON object, required)` - json object with addresses as keys and amounts as values.</br>`address`: `(numeric, required)` the address to send to as the key and the amount in DCR as the value.<br /><br />`{"address": n.nnn, ...}`| | |||
There was a problem hiding this comment.
Missing a space before the n in [{"amount":n, "txid": "hash", "vout": n}, ...].
There was a problem hiding this comment.
Now that there are two amounts, it should probably specifically call out that the latter amounts are outputs amounts.
There was a problem hiding this comment.
Finally, I noticed that the address description is inaccurate. Notice it says:
address: (numeric, required) the address to send to as the key and the amount in DCR as the value.
Which indicates it should literally be the key address. It's not, rather it's actually the address to send the specified amount to.
This adds an amount field to TransactionInput intended for specifying the prev out amount when creating a transaction. createraw/ssrtx/sgentx/transaction rpcs are also updated accordingly as well as associated tests. A typo in assignField is also corrected.
davecgh
approved these changes
Jun 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an amount field to
TransactionInputintended for specifying the prev out amount when creating a transaction.createraw/ssrtx/sgentx/transactionrpcs are also updated accordingly as well as associated tests.A typo in
assignFieldwas also corrected.Resolves #1280