txscript: Introduce repeated syntax to test data. #1299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Jun 14, 2018
davecgh
force-pushed
the
txscript_parse_repreated_data_syntax
branch
2 times, most recently
from
b05507d
to
bbe896d
Compare
This improves the test data short script form syntax to allow repeated raw and quoted data and updates several tests to make use of it. While here, it also corrects a few tests to actually test what they were originally intended to test but were not updated correctly for Decred limit changes. In particular, the following tests were corrected: - The negative test that ensures to exceeding the maximum allowed script size results in failure - The positive test that ensures a fully maxed out script (max script size, max element size push, max opcodes, and max stack items) succeeds - The positive test that ensures OP_RESERVED does not count towards the opcode limit
davecgh
force-pushed
the
txscript_parse_repreated_data_syntax
branch
from
bbe896d
to
9e23c8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the test data short script form syntax to allow repeated raw and quoted data and updates several tests to make use of it.
While here, it also corrects a few tests to actually test what they were originally intended to test but were not updated correctly for Decred limit changes. In particular, the following tests were corrected:
OP_RESERVEDdoes not count towards the opcode limit