multi: Cleanup recent alt DNS names additions. #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnldd
suggested changes
Oct 11, 2018
rpcserver_test.go
Outdated
| @@ -12,7 +12,7 @@ import ( | |||
| "bytes" | |||
| "crypto/x509" | |||
| "encoding/pem" | |||
| "flag" | |||
|
|
|||
davecgh
force-pushed
the
rpcserver_cleanup_altdns_additions
branch
from
080133d
to
ed2fea4
Compare
dnldd
approved these changes
Oct 11, 2018
This cleans up code recently added to support the --altdnsnames flag and
DCRD_ALT_DNSNAMES environment variable to match the project standards,
simplify it, and correct some issues with standalone test binaries.
- Gets rid of the setup func which had several issues:
- It was creating a file that was not needed (and without even
checking the error)
- Since it was parsing flags and missing with os.Args in a func, it
was not possible to individual run the test funcs without failure
due to the additional flags
- Performs the flag parsing and removal in an init func that only runs
once when the tests are run (and before TestMain)
- Avoids creating empty objects when nil will suffice
- Uses full sentences and periods in the comment and properly spaces
them out so they are consistent with the rest of the code
- Adds comments to all of the added test functions as required by the
code contribution guidelines
- Closes the create temp files before trying to write to them in the cert
generation
- Defers the removal of the temp files directly after they are created so
they are removed properly if the next one fails to create
- Uses consistent camel case in the variable names
davecgh
force-pushed
the
rpcserver_cleanup_altdns_additions
branch
from
ed2fea4
to
5b8450a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up code recently added to support the
--altdnsnamesflag andDCRD_ALT_DNSNAMESenvironment variable to match the project standards, simplify it, and correct some issues with standalone test binaries.os.Argsin a func, it was not possible to individual run the test funcs without failure due to the additional flagsinitfunc that only runs once when the tests are run (and beforeTestMain)