blockchain: Notify stake states after connected block #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an accepted block is attached to the main chain, potentially three notifications are emitted: NTBlockConnected, NTSpentAndMissedTickets, and NTNewTickets. This change moves NTBlockConnected to being the first notification, followed by NTSpentAndMissedTickets and NTNewTickets. This is important for applications which react to the stake notifications since they will have already been notified of the most recently connected block. For example, dcrwallet uses the spentandmissedtickets JSON-RPC notification to create revocation transactions for missed votes. However, if the missed tickets are notified before the connected block, a race is possible where the revocations are rejected as they double spend a vote on what wallet believes is still the main chain tip block. This is considered a patch bump to the JSON-RPC API semantic version due to affecting and improving the ordering of the blockconnected and spentandmissedtickets notifications.
dnldd
approved these changes
Nov 5, 2018
davecgh
approved these changes
Nov 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an accepted block is attached to the main chain, potentially
three notifications are emitted: NTBlockConnected,
NTSpentAndMissedTickets, and NTNewTickets. This change moves
NTBlockConnected to being the first notification, followed by
NTSpentAndMissedTickets and NTNewTickets.
This is important for applications which react to the stake
notifications since they will have already been notified of the most
recently connected block. For example, dcrwallet uses the
spentandmissedtickets JSON-RPC notification to create revocation
transactions for missed votes. However, if the missed tickets are
notified before the connected block, a race is possible where the
revocations are rejected as they double spend a vote on what wallet
believes is still the main chain tip block.
This is considered a patch bump to the JSON-RPC API semantic version
due to affecting and improving the ordering of the blockconnected and
spentandmissedtickets notifications.