config: add --maxsameip to limit # of conns to same IP #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
reviewed
Nov 7, 2018
There was a problem hiding this comment.
I haven't looked at this closely, but I'm pretty sure you're going to either need to whitelist 127.0.0.1 in the rpctest harness since it makes multiple connections or otherwise allow the tests more connections. This will cause an issue with simnet setups as well.
Alternatively, perhaps the code should automatically whitelist localhost for both IPv4 and IPv6?
davecgh
changed the title
davecgh
previously requested changes
Nov 7, 2018
davecgh
reviewed
Nov 14, 2018
davecgh
previously requested changes
Nov 14, 2018
davecgh
approved these changes
Nov 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.