rpcserver: Do not rebroadcast stake transactions. #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrick
approved these changes
Jan 17, 2018
alexlyp
approved these changes
Jan 17, 2018
This modifies the sendrawtransaction handler to avoid adding stake transactions to the rebroadcast logic since they should not be perpetually rebroadcast without special handling to remove them under certain circumstances other than showing up in a block. This is particularly applicable to votes which are only valid for a specific block and are time sensitive, but it also applies to ticket purchases which are only valid for the duration of a stake difficulty interval, and revocations which could be invalidated in a reorg due to the associated missed or expired ticket being resurrected in a reorg.
davecgh
force-pushed
the
rpc_no_rebroadcast_stake_txns
branch
from
de9ca11
to
35b6f06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the
sendrawtransactionhandler to avoid adding stake transactions to the rebroadcast logic since they should not be perpetually rebroadcast without special handling to remove them under certain circumstances other than showing up in a block.This is particularly applicable to votes which are only valid for a specific block and are time sensitive, but it also applies to ticket purchases which are only valid for the duration of a stake difficulty interval, and revocations which could be invalidated in a reorg due to the associated missed or expired ticket being resurrected in a reorg.