multi: add specialized rebroadcast handling for stake txs. #979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
requested changes
Jan 22, 2018
server.go
Outdated
| @@ -179,6 +180,8 @@ type server struct { | |||
| txIndex *indexers.TxIndex | |||
| addrIndex *indexers.AddrIndex | |||
| existsAddrIndex *indexers.ExistsAddrIndex | |||
|
|
|||
| pendingInvs map[wire.InvVect]interface{} | |||
There was a problem hiding this comment.
Please don't move this out of the rebroadcast handler. It's no longer concurrent safe moving it out here. You've introduced races by doing this.
blockmanager.go
Outdated
| @@ -2077,6 +2077,13 @@ func (b *blockManager) handleNotifyMsg(notification *blockchain.Notification) { | |||
| } | |||
|
|
|||
| for _, stx := range block.STransactions()[0:] { | |||
| // Remove rebroadcast inventory for revocations | |||
| if txType := stake.DetermineTxType(stx.MsgTx()); txType == stake.TxTypeSSRtx { | |||
There was a problem hiding this comment.
This section is incorrect in at least 2 ways:
- A block being connected does not invalidate a revocation. It's only invalidated if it was a revocation for a ticket which was previously invalid, but is now valid again
- It's skipping the required mempool updates below due to the continue
blockmanager.go
Outdated
| @@ -2173,6 +2180,13 @@ func (b *blockManager) handleNotifyMsg(notification *blockchain.Notification) { | |||
| } | |||
|
|
|||
| for _, tx := range block.STransactions()[0:] { | |||
| // Remove rebroadcast inventory for revocations | |||
| if txType := stake.DetermineTxType(tx.MsgTx()); txType == stake.TxTypeSSRtx { | |||
There was a problem hiding this comment.
Same here regarding this being incorrect. A block being disconnected does not necessarily invalidate a revocation.
dnldd
force-pushed
the
rebroadcastdifftxtypes
branch
from
fe5b50a
to
6f2713d
Compare
dnldd
force-pushed
the
rebroadcastdifftxtypes
branch
from
6f2713d
to
0790e6d
Compare
dnldd
force-pushed
the
rebroadcastdifftxtypes
branch
7 times, most recently
from
2ca40aa
to
df39b0a
Compare
dnldd
force-pushed
the
rebroadcastdifftxtypes
branch
from
df39b0a
to
2f27301
Compare
davecgh
approved these changes
Jul 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #975