Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eth: update solc and abigen workflow #1626

Merged
merged 1 commit into from
May 31, 2022
Merged

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented May 25, 2022

Wtih go-ethereum 1.10.18, abigen no longer has compiler invocation support, and we must use solc directly.

Resolves #1625

Wtih go-ethereum 1.10.18, abigen no longer has solidity compiler
support, and we must use solc directly.
@chappjc chappjc linked an issue May 25, 2022 that may be closed by this pull request
Copy link
Contributor

@martonp martonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well.

Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have changes when doing ./updatecontract.sh 0

I'm using:

$ solc --version
solc, the solidity compiler commandline interface
Version: 0.8.6+commit.11564f7e.Linux.g++
$ abigen --version
abigen version 1.10.2-stable-97d11b01

Maybe can add something about the versions in the README? Also we have a testnet address now you could add.

@chappjc
Copy link
Member Author

chappjc commented May 30, 2022

I have changes when doing

Changes other than what's in the PR? To Bin or other parts of contract.go?

$  solc --version
solc, the solidity compiler commandline interface
Version: 0.8.6+commit.11564f7e.Linux.g++
$  abigen --version
abigen version 1.10.18-stable

Running an old abigen?

@JoeGruffins
Copy link
Member

Running an old abigen?

Yes. No changes after updating to 1.10.18-stable

@chappjc chappjc merged commit d637a13 into decred:master May 31, 2022
@chappjc chappjc deleted the abigen-solc branch May 31, 2022 16:02
@chappjc chappjc added this to the 0.5 milestone Aug 26, 2022
@chappjc chappjc added the ETH label Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

abigen --sol no longer works
4 participants