assets: add a DCR backend #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
commented
Aug 23, 2019
buck54321
commented
Aug 23, 2019
buck54321
commented
Aug 23, 2019
chappjc
requested changes
Aug 23, 2019
|
I implemented P2SH support, as well as allowing vote and revocation outputs to be spent after maturity. I also did multi-sig, though only as P2SH. Enabling multi-sig requires a change to the DEX specification to make the |
chappjc
reviewed
Aug 27, 2019
buck54321
force-pushed
the
dcr
branch
2 times, most recently
from
b594b3c to
cd26107
Compare
chappjc
reviewed
Sep 3, 2019
buck54321
commented
Sep 6, 2019
chappjc
reviewed
Sep 6, 2019
chappjc
reviewed
Sep 6, 2019
chappjc
reviewed
Sep 6, 2019
chappjc
approved these changes
Sep 6, 2019
A DCR backend for gathering information about UTXOs and signatures. Also DEXAsset, a common interface for asset backends, which the DCR backend implements. Includes both offline and live unit tests.
Adds a DEXTx interface for getting transaction information and using it to verify swap contracts and spend outputs.
Adds P2SH support and multi-sig. Also adds parsing of stake versions of supported script types so that vote and revocation outputs can be used as inputs after maturation.
These changes modify the DCR backend constructor to be the same as the BTC constructor. The choice of network is based on a DEX supplied ID, and other configuration settings are loaded from a specified filepath.
Adds support for Edwards and Schnorr signatures. Modifies the live utxo test to take more complete statistics.
Also changes UTXO.ScriptSize to UTXO.SpendSize, since the size is more than just the sig script.
|
Should be good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a dcrd RPC client backend and a DEX backend interface. Methods for handling transactions, UTXOs, and swap contracts are implemented.
There are offline tests and live tests. Use the
-tags=drclivetag to run the live tests. The live tests assume a mainnet node and a pretty default configuration, so may need to tweak things if yours are different.I'm sure the interface will need more methods. For instance it doesn't have a way to monitor the health of the backend itself. It should probably be clear to the DEX when the backend is not connected to the node or such.