Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update node deps to deal with babel build error #223

Merged
merged 1 commit into from
Apr 1, 2020
Merged

update node deps to deal with babel build error #223

merged 1 commit into from
Apr 1, 2020

Conversation

chappjc
Copy link
Member

@chappjc chappjc commented Mar 25, 2020 •
edited
Loading

Resolves #222

Note that this does not bump the major versions of stylelint:

$   npm out
Package                    Current  Wanted  Latest  Location
stylelint                   12.0.1  12.0.1  13.2.1  dexclient
stylelint-config-standard   19.0.0  19.0.0  20.0.0  dexclient

@chappjc
Copy link
Member Author

chappjc commented Mar 25, 2020 •
edited
Loading

We might also consider checking in package-lock.json (and using npm ci) now so that we're all on the same versions when testing.

buck54321
buck54321 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks. I'll look into the stylelint updates.

@chappjc chappjc merged commit 5372499 into decred:master Apr 1, 2020
@chappjc chappjc deleted the babel-up branch April 1, 2020 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buck54321 buck54321 buck54321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

client/webserver/site: babel build error
2 participants
@chappjc @buck54321