webserver: fix live-test #2464
Merged
webserver: fix live-test #2464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set "initErrors" to false to allow for error free account creation. - Initiate and use math/rand.Rand instead of deprecated math/rand.Seed. - Set the Rate and MatchID feild for user order match. - Use caser.Title instead of deprecated string.Title. Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
JoeGruffins
reviewed
Aug 7, 2023
There was a problem hiding this comment.
I actually cannot run the tests on master because I have ipv6 turned off on my machine.
--- FAIL: TestServer (0.01s)
live_test.go:2036: Connect error: connect failure: Can't listen on [::1]:54321. web server quitting: listen tcp [::1]:54321: socket: address family not supported by protocol
This diff seems to give me a panic:
$ go test --tags=live
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x531a58]
goroutine 1 [running]:
math/rand.(*Rand).Int63(...)
/usr/lib/go/src/math/rand/rand.go:95
math/rand.(*Rand).Int31(...)
/usr/lib/go/src/math/rand/rand.go:109
math/rand.(*Rand).Int31n(0x0, 0xa)
/usr/lib/go/src/math/rand/rand.go:144 +0x38
math/rand.(*Rand).Intn(0x1736f60?, 0xc000041e60?)
/usr/lib/go/src/math/rand/rand.go:182 +0x2e
decred.org/dcrdex/client/webserver.mkDexAsset({0x199f064, 0x3})
/home/joe/git/dcrdex/client/webserver/live_test.go:236 +0xe5
decred.org/dcrdex/client/webserver.init()
/home/joe/git/dcrdex/client/webserver/live_test.go:300 +0x594
exit status 2
FAIL decred.org/dcrdex/client/webserver 0.023s
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Whoops! Fixed in fd6cb85. I also addressed this |
JoeGruffins
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are just some changes I think the webserver live test can use. I think it needs more improvement and could work on them little by little.