Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multi: show more bond info on dexsettings page #2485

Merged
merged 10 commits into from
Oct 13, 2023
Merged

multi: show more bond info on dexsettings page #2485

merged 10 commits into from
Oct 13, 2023

Conversation

ukane-philemon
Copy link
Contributor

UI changes:
Screenshot 2023-08-23 at 3 16 09 AM

@ukane-philemon ukane-philemon changed the title multi: show more bond info dexsettings page multi: show more bond info on dexsettings page Aug 23, 2023
JoeGruffins
JoeGruffins approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could add some more scroll over info? For example:
Current Tier "Number of active bonds that have not yet reached the expiry threshold."
Pending Bonds "Number of bonds that will be active when enough on chain confirmations have been reached. These do not yet count towards the current tier."
Expired Bonds "Bonds that are still locked but have passed the expiry threshold. These do not count towards current tier and will be refunded."

@ukane-philemon
Copy link
Contributor Author

Could add some more scroll over info?

Sure! Thanks for reviewing.

@ukane-philemon
Copy link
Contributor Author

With tooltips:

Screenshot 2023-08-28 at 9 18 20 PM

@ukane-philemon ukane-philemon marked this pull request as draft September 18, 2023 14:46
@ukane-philemon ukane-philemon force-pushed the show-more-bond-info branch 2 times, most recently from 05ecbde to a0acd7e Compare September 20, 2023 12:45
@ukane-philemon
Copy link
Contributor Author

ukane-philemon commented Sep 20, 2023 •
edited
Loading

@buck54321, I've addressed the requirements as mentioned here(#2485 (comment)). Please let me know if I missed anything.

bond_changes.mov

PS: Saw some weird webview log here(not related to this PR though): https://github.com/ukane-philemon/dcrdex/actions/runs/6248690677/job/16963818304

@ukane-philemon ukane-philemon marked this pull request as ready for review September 20, 2023 13:00
buck54321
buck54321 reviewed Sep 25, 2023
View reviewed changes
client/webserver/api.go Outdated Show resolved Hide resolved
buck54321
buck54321 requested changes Oct 3, 2023
View reviewed changes
client/webserver/site/src/js/dexsettings.ts Outdated Show resolved Hide resolved
client/webserver/site/src/js/doc.ts Outdated Show resolved Hide resolved
ukane-philemon and others added 9 commits October 4, 2023 23:02
@ukane-philemon
multi: show more bond info dexsettings page
8bcd6a4
@ukane-philemon
review changes
8bdc192 
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
@ukane-philemon
display only important bond information
a67b213 
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
@ukane-philemon
use feeBuffer as provided by the frontend
288c880 
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
@ukane-philemon
go fmt
140396a 
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
@ukane-philemon
allow wallet to provide bond feeBuffer if feeBuffer is zero
cbbcab9 
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
@ukane-philemon
review changes
7f5ff14 
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
@buck54321 @ukane-philemon
showFiatValue on pattern
184d6f2
@ukane-philemon
bust caches
ff32e6c 
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
@buck54321 buck54321 merged commit 89ff74f into decred:master Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeGruffins JoeGruffins JoeGruffins approved these changes

@buck54321 buck54321 buck54321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ukane-philemon @buck54321 @JoeGruffins