-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wiki: Update wiki to reflect current DEX client account creation flow #2538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
reviewed
Sep 29, 2023
JoeGruffins
approved these changes
Oct 2, 2023
ukane-philemon
force-pushed
the
wiki-update
branch
from
October 2, 2023 13:40
c64a7f7
to
7dc2cb3
Compare
buck54321
requested changes
Oct 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The markdown linter has a lot of complaints. It looks like we have that set to run with
continue-on-error: true
which is why we're not catching these errors with e.g. ./run_tests.sh
.
Oh, yh. Seen. |
- Move DEX Account creation guide from Client-Installation-and-Configuration.md to DEX-Trading-Account-Management.md - Update several old wiki images and add new ones. - Update Testnet-Testing.md, Client-Installation-and-Configuration.md, and DEX-Trading-Account-Management.md Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
ukane-philemon
force-pushed
the
wiki-update
branch
from
October 17, 2023 23:51
7dc2cb3
to
2e1a019
Compare
buck54321
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates several wiki pages to reflect the new DEX client account creation flow and moves some information to the most appropriate page.
Client-Installation-and-Configuration.md
toDEX-Trading-Account-Management.md
Testnet-Testing.md
,Client-Installation-and-Configuration.md
, andDEX-Trading-Account-Management.md
The links in
Client-Installation-and-Configuration.md
pointing toDEX-Trading-Account-Management.md
need the DEX-Trading-Account-Management page to be pushed to the main wiki for it to work.Check out the changes preview here: https://github.com/ukane-philemon/dcrdex/wiki