ui: External link handling in dexc-desktop #2541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterzen
force-pushed
the
webview-external-links
branch
3 times, most recently
from
e66f68f to
173e8f0
Compare
buck54321
requested changes
Sep 29, 2023
|
Bump |
peterzen
force-pushed
the
webview-external-links
branch
from
173e8f0 to
fc347c8
Compare
buck54321
requested changes
Nov 2, 2023
client/cmd/dexc-desktop/app.go
Outdated
| err = exec.Command("rundll32", "url.dll", "FileProtocolHandler", url).Start() | ||
| } | ||
| if err != nil { | ||
| log.Errorf(err.Error()) |
peterzen
force-pushed
the
webview-external-links
branch
from
e3d81c7 to
db9d46c
Compare
buck54321
approved these changes
Nov 2, 2023
buck54321
added a commit
to buck54321/dcrdex
that referenced
this pull request
Nov 8, 2023
Bug from decred#2541. Was redirecting _blank links regardless of whether we were on WebKit. Also added simnet entries for all assets in CoinExplorers. They are the same as mainnet, and will go to nowhere, but at least they'll be links.
buck54321
added a commit
that referenced
this pull request
Nov 10, 2023
Bug from #2541. Was redirecting _blank links regardless of whether we were on WebKit. Also added simnet entries for all assets in CoinExplorers. They are the same as mainnet, and will go to nowhere, but at least they'll be links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the handling/behavior of links that are to open in a new window (
target="_blank"). When the UI runs within a Webview window, clicks on those links are passed through to the default URL handler of the OS, instead of being handled inside the WV.Closes #2453