ui: fix unsupported asset bugs on markets view #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buck54321
force-pushed
the
fix-unsupported-asset-stuff
branch
from
4dd77b3 to
e13a79e
Compare
ukane-philemon
approved these changes
Sep 29, 2023
| @@ -1742,7 +1742,7 @@ export default class MarketsPage extends BasePage { | |||
| handleBookRoute (note: BookUpdate) { | |||
| app().log('book', 'handleBookRoute:', note) | |||
| const mktBook = note.payload | |||
| const [b, q] = [app().assets[this.market.base.id], app().assets[this.market.quote.id]] | |||
There was a problem hiding this comment.
This was the culprit and reading initial from app() which we’ve been doing elsewhere. Thanks for fixing. AFK so can’t run it now but looks gtg.
buck54321
force-pushed
the
fix-unsupported-asset-stuff
branch
from
52e87b2 to
4ca4a20
Compare
martonp
approved these changes
Oct 1, 2023
JoeGruffins
approved these changes
Oct 3, 2023
buck54321
force-pushed
the
fix-unsupported-asset-stuff
branch
from
4ca4a20 to
396d103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #2532