Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dex/testing: rationalize imports #2570

Merged
merged 3 commits into from
Nov 6, 2023

Conversation

dev-warrior777
Copy link
Contributor

Update imports

@dev-warrior777 dev-warrior777 changed the title de/testing: rationalize imports dex/testing: rationalize imports Oct 17, 2023
@dev-warrior777 dev-warrior777 marked this pull request as ready for review October 17, 2023 17:47
Comment on lines 31 to 34
"decred.org/dcrdex/client/asset/btc/electrum"

"github.com/btcsuite/btcd/wire"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this blank line please.

	This test takes a while to complete and accesses internet
	so it should not be run as part of run_test.sh
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, but there are no net changes here, and there's no reason to have moved the build tag. Please avoid opening PRs that do nothing.

@buck54321 buck54321 merged commit 541b7d9 into decred:master Nov 6, 2023
5 checks passed
@dev-warrior777
Copy link
Contributor Author

OK, but there are no net changes here, and there's no reason to have moved the build tag. Please avoid opening PRs that do nothing.

The change was to remove bcash import and use btcd one. Was that lost?

@dev-warrior777 dev-warrior777 deleted the electrum_test branch March 6, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants