Mobile companion app #2715
Mobile companion app #2715
Conversation
peterzen
force-pushed
the
tor
branch
2 times, most recently
from
59e518c
to
278b70c
Compare
peterzen
force-pushed
the
tor
branch
3 times, most recently
from
2fc37fe
to
74870f8
Compare
peterzen
force-pushed
the
tor
branch
2 times, most recently
from
d725dd6
to
c3df1bc
Compare
|
|
||
| if cfg.Logger != nil { | ||
| log = cfg.Logger | ||
| } |
There was a problem hiding this comment.
If log is nil we should error or we will get a panic later. Will we be calling New more than once? In that case maybe we shouldn't use a shared log.
There was a problem hiding this comment.
New is called repeatedly in webserver_test.go, this change fixes a race:
bf0a925****
There was a problem hiding this comment.
I'm not actually sure this is the most elegant solution btw, suggestions appreciated.
There was a problem hiding this comment.
Can you just make a new logger for every test? Is the problem using the same logger for multiple tests at the same time? I thought the logger could handle concurrent logs though...
There was a problem hiding this comment.
I see the problem now, we change the logger as it is being used.
imo the correct way to solve this is to make log part of the WebServer struct and remove the package level one. It can't be used before being initiated with New anyhow, so there's no reason for it to be package level.
|
Looks really nice! I didn't realize we could do something like this. Left side could use padding here: Sorry resolution is so high, putting in dropdown... more issuesI'm not seeing an app icon. I thought there was one though: Unable to make a new account for some reason: |
There was a problem hiding this comment.
So I was thinking if we can kill two birds with one stone and have the mobile companion as a flutter application. That way we can benefit both android and ios users.
@buck54321, @JoeGruffins, @peterzen what do you think?
| @@ -244,6 +244,38 @@ func (s *WebServer) handleGenerateQRCode(w http.ResponseWriter, r *http.Request) | |||
| } | |||
| } | |||
|
|
|||
| // handleGenerateQRCode is the handler for the '/generateqrcode' page request | |||
| func (s *WebServer) handleGenerateCompanionAppQRCode(w http.ResponseWriter, r *http.Request) { | |||
|
|
|||
There was a problem hiding this comment.
can remove this space
| func (s *WebServer) handleGenerateCompanionAppQRCode(w http.ResponseWriter, r *http.Request) { | ||
|
|
||
| var url string | ||
|
|
There was a problem hiding this comment.
can remove this space
| // Create auth token and append it to the URL for authTokenMiddleware to pick up. | ||
| // TODO save this token in the DB to make it permanent? |
There was a problem hiding this comment.
Can this token changed at any point in time?
| cm.Wait() | ||
| wg.Done() |
There was a problem hiding this comment.
We might want to block until s.ctx cancellation here.
| } | ||
|
|
||
| android { | ||
| namespace 'org.decred.dex.dexandroid' |
There was a problem hiding this comment.
just org.decred.dex should be okay, no?
| compileSdk 34 | ||
|
|
||
| defaultConfig { | ||
| applicationId "org.decred.dex.dexandroid" |
There was a problem hiding this comment.
just org.decred.dex should be okay, no?
This adds a tor hidden service, and a settings dialog that generates the QR code of the .onion URL for pairing with a mobile app.
The Android app code is under
/companionapp/android. This can be loaded into Android Studio for building and running in the AVD emulator.Pairing dialog