multi: USDC Bridge between eth and polygon #2797
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements the CCTP protocol to bridge native USDC between eth and polygon.
JoeGruffins
reviewed
Jun 14, 2024
Comment on lines
+1317
to
+1319
| fmt.Println("~~~~~~", tokenCfg.AssetID, usdcEthID, usdcPolygonID) | ||
| if tokenCfg.AssetID == usdcEthID || tokenCfg.AssetID == usdcPolygonID { | ||
| fmt.Println("returning bridge wallet") |
There was a problem hiding this comment.
Did you mean to leave in these prints? Can trace log?
Comment on lines
673
to
+674
|
|
||
| type Bridger interface { |
There was a problem hiding this comment.
Can you add a comment for Bridger.
| value (int): The amount of tokens to bridge. | ||
| burnTxID (string): The transaction ID of the burn transaction. Returned from the burn command. | ||
| mintInfo (string): The information needed to mint tokens. Returned from the getmintinfo command.`, | ||
| }, |
There was a problem hiding this comment.
Can you add returns? Whats 2?
$ ./bwctl -p abc -p "" --testnet bridge checkbridgeapproval 60001
2
| return createResponse(bridgeRoute, approvalStatus, nil) | ||
| } | ||
|
|
||
| func handleApproveBridge(s *RPCServer, params *RawParams) *msgjson.ResponsePayload { |
There was a problem hiding this comment.
Could also unlock the wallet in this method if locked by requiring password params. It looks like we haven't been doing that though, so feel free to ignore.
Comment on lines
+1269
to
+1271
| if len(params.Args) != 2 { | ||
| return usage(bridgeRoute, fmt.Errorf("expected 1 args, got %d", len(params.Args))) | ||
| } |
There was a problem hiding this comment.
$ ./bwctl -p abc -p "" --testnet bridge getmintinfo ed90645fc6058b27e11c71060b0b55d5f55db55f7365610359c6f5768f4cffd5
expected 1 args, got 1
|
I guess it would be bad to lose the txids between burn and mint. Need to log them alot and also save in a db somewhere at some point? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the CCTP protocol to bridge native USDC between eth and polygon.
This will be used to support running market making bots doing rebalances between the local wallet and a centralized exchange when the exchange does not support withdrawing USDC to Polygon. Binance supports neither deposits nor withdrawals to Polygon. Coinbase (coming soon) supports deposits, but not withdrawals.