client/dcr: Mixing Tx History #2853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Jul 5, 2024
buck54321
reviewed
Jul 9, 2024
buck54321
reviewed
Aug 12, 2024
client/asset/dcr/dcr.go
Outdated
Comment on lines
4830
to
4851
| previouslySynced := dcr.previouslySynced.Load() | ||
| if err != nil { | ||
| dcr.previouslySynced.Store(false) | ||
| return | ||
| } | ||
| dcr.previouslySynced.Store(synced) | ||
|
|
||
| if !previouslySynced && synced { | ||
| dcr.tipMtx.RLock() | ||
| tip := dcr.currentTip | ||
| dcr.tipMtx.RUnlock() | ||
|
|
||
| dcr.syncTxHistory(dcr.ctx, uint64(tip.height)) | ||
| } |
There was a problem hiding this comment.
A little bit cleaner, I think
if wasSynced := dcr.previouslySynced.Swap(synced); synced && !wasSynced {
dcr.tipMtx.RLock()
tip := dcr.currentTip
dcr.tipMtx.RUnlock()
dcr.syncTxHistory(dcr.ctx, uint64(tip.height))
}
This diff handles identifying decred mixing transactions when adding them to the transaction history. Also, it updates the UI to allow hiding mixing transactions.
buck54321
approved these changes
Aug 12, 2024
| @@ -971,6 +974,7 @@ export default class WalletsPage extends BasePage { | |||
| for (const b of assetSelect.children) b.classList.remove('selected') | |||
| this.assetButtons[assetID].bttn.classList.add('selected') | |||
| this.selectedAssetID = assetID | |||
| this.page.hideMixTxsCheckbox.checked = true | |||
There was a problem hiding this comment.
This should be remembered, but I'm not gonna push it now.
Comment on lines
+1874
to
+1883
| async getTxHistory (assetID: number, hideMixTxs: boolean, after?: string) : Promise<TxHistoryResult> { | ||
| let numToFetch = 10 | ||
| if (hideMixTxs) numToFetch = 15 | ||
|
|
||
| const res : TxHistoryResult = { txs: [], lastTx: false } | ||
| let ref = after | ||
|
|
||
| for (let i = 0; i < 40; i++) { | ||
| const currRes = await app().txHistory(assetID, numToFetch, ref) | ||
| if (currRes.txs.length > 0) { |
There was a problem hiding this comment.
This is kind of a hack. We should be passing a filter all the way in to the wallet.
buck54321
pushed a commit
that referenced
this pull request
Aug 12, 2024
* client/dcr: Mixing Tx History This diff handles identifying decred mixing transactions when adding them to the transaction history. Also, it updates the UI to allow hiding mixing transactions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff handles identifying decred mixing transactions when adding them to the transaction history. For RPC wallets, a separate transaction history db is created for each set of unmixed/trading/mixed accounts configuration.
Closes #2824