Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: Add ExchangeWalletCustom to support external btc-clone wallets #2855

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ukane-philemon
Copy link
Contributor

This PR is an improved version of #2636.

  1. Add an ExchangeWalletCustom
  2. Revert changes in d7a5488
  3. expose spv scanFilters method
  4. Export btc.Wallet methods. This aligns with the existing pattern - dcr.Wallet methods are exported. Custom wallets would now implement the btc.Wallet interface directly.
  5. Expose dcr wallet options.

Each of these changes is in a separate commit to ease review.
Other related commit: https://github.com/decred/dcrdex/pull/1227/files#diff-cd95defa7320b76287f90152b40ee5ec5edec59ca9af2eb9579ecda539ece20a

@ukane-philemon ukane-philemon changed the title multi: Add ExchangeWalletCustom to support extrnal wallets multi: Add ExchangeWalletCustom to support external btc-clone wallets Jul 2, 2024
@ukane-philemon
Copy link
Contributor Author

cc: @dmigwi

ukane-philemon and others added 6 commits September 6, 2024 10:05
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Signed-off-by: Philemon Ukane <ukanephilemon@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants