mm: Internal transfers #2891
Open
mm: Internal transfers #2891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff updates the market maker to attempt to allocate available funds to bots before doing a deposit or a withdrawal. By doing this, unnecessary deposits or withdrawals may be avoided. This will be attempted even if rebalancing is turned off.
JoeGruffins
approved these changes
Aug 5, 2024
Comment on lines
+426
to
+427
| // ** IMPORTANT ** No mutexes is should be locked when calling this | ||
| // function. |
There was a problem hiding this comment.
Suggested change
| // ** IMPORTANT ** No mutexes is should be locked when calling this | |
| // function. | |
| // ** IMPORTANT ** No mutexes should be locked when calling this | |
| // function. |
Comment on lines
+2943
to
+2944
| dexDiffs = map[uint32]int64{u.baseID: int64(toWithdraw)} | ||
| cexDiffs = map[uint32]int64{u.baseID: -int64(toWithdraw)} |
There was a problem hiding this comment.
No need to make a new map? here and above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This diff updates the market maker to attempt to allocate available funds to bots before doing a deposit or a withdrawal. By doing this, unnecessary deposits or withdrawals may be avoided. This will be attempted even if rebalancing is turned off.