mm: Close book feeds #2907
Merged
mm: Close book feeds #2907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Book feeds were not being closed, leading to warning logs.
|
LGTM |
buck54321
requested changes
Aug 12, 2024
client/mm/mm_simple_arb.go
Outdated
| @@ -465,6 +465,7 @@ func (a *simpleArbMarketMaker) botLoop(ctx context.Context) (*sync.WaitGroup, er | |||
| a.rebalance(epoch.Current) | |||
| } | |||
| case <-ctx.Done(): | |||
| bookFeed.Close() | |||
There was a problem hiding this comment.
Put it up after defer wg.Done() please. Here and two other places.
client/mm/mm_simple_arb.go
Outdated
| @@ -465,6 +465,7 @@ func (a *simpleArbMarketMaker) botLoop(ctx context.Context) (*sync.WaitGroup, er | |||
| a.rebalance(epoch.Current) | |||
| } | |||
| case <-ctx.Done(): | |||
| bookFeed.Close() | |||
There was a problem hiding this comment.
Looks like you need to close this if you get an error from SubscribeMarket above too.
buck54321
approved these changes
Aug 12, 2024
buck54321
pushed a commit
that referenced
this pull request
Aug 12, 2024
* mm: Close book feeds Book feeds were not being closed, leading to warning logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Book feeds were not being closed, leading to warning logs.