multi: implement user onboarding game #2921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ukane-philemon
suggested changes
Aug 20, 2024
| func (dcr *ExchangeWallet) RedeemGeocode(code []byte, msg string) (dex.Bytes, uint64, error) { | ||
| msgLen := len([]byte(msg)) | ||
| if msgLen > stdscript.MaxDataCarrierSizeV0 { | ||
| return nil, 0, fmt.Errorf("message is too long. must be %d > %d", msgLen, stdscript.MaxDataCarrierSizeV0) |
There was a problem hiding this comment.
nit: must be %d < %d
| // prepaid bond (code is a prepaid bond). If the user is not registered with | ||
| // dex.decred.org yet, the dex will be added first. | ||
| func (c *Core) RedeemGeocode(appPW, code []byte, msg string) (dex.Bytes, uint64, error) { | ||
| const dcrBipID = 42 |
There was a problem hiding this comment.
We should use the const from the network pkg? And say that this supports only dcr codes in the comment.
martonp
reviewed
Aug 20, 2024
Comment on lines
+10772
to
+10779
| host := "dex.decred.org:7232" | ||
| switch c.net { | ||
| case dex.Testnet: | ||
| host = "bison.exchange:17232" | ||
| case dex.Simnet: | ||
| host = "127.0.0.1:17273" | ||
| } | ||
| cert := CertStore[c.net][host] |
There was a problem hiding this comment.
Host should be a param. Maybe make it be part of the code?
There was a problem hiding this comment.
I agree that the server should be a parameter, but it can't be "part of the code". If we expand this, we'll just have to note the server on the paper in the cache. That would, of course, add friction when the user redeems, so I'm avoiding that for now. May change later.
There was a problem hiding this comment.
Just to follow up, here is my reasoning for hard-coding the hosts.
- When we make the host a parameter, we will be adding more steps and new things to break.
- We could start with radio buttons for our "known servers", but there is only one public mainnet server right now anyway.
- We could add an input field for a custom host, but since we're so late in the release cycle, I want to minimize new code, and I think there's a balance to be struck
martonp
approved these changes
Aug 22, 2024
buck54321
added a commit
to buck54321/dcrdex
that referenced
this pull request
Aug 23, 2024
* implement geogame * internationalize * remove superfluous module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces functionality to play a geocache-like marketing game wherein we publish the GPS coordinates to caches placed in the real world that contain a code redeemable for DCR and a prepaid bond. Here's how it works
The user also has the option to encode a message of up to 256 characters in their redemption transaction.
Tested on testnet and mainnet.