Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: filter out injected non-existent language #2930

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

buck54321
Copy link
Member

This was a patch we did on the release-v0.6 branch (#2596) that somehow never made it into master. This is to address a bug in Electron that adds a non-existent language code into navigator.languages.

@@ -51,11 +50,15 @@ const BipSymbolIDs: Record<string, number> = {};

const BipSymbols = Object.values(BipIDs)

const RateEncodingFactor = 1e8 // same as value defined in ./orderutil
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copying here to avoid a circular dependency.

@JoeGruffins
Copy link
Member

Maybe can do a npm audit fix while you are here.

$ npm audit
# npm audit report

micromatch  <4.0.8
Severity: moderate
Regular Expression Denial of Service (ReDoS) in micromatch - https://github.com/advisories/GHSA-952p-6rrq-rcjv

@buck54321 buck54321 merged commit 32d88bc into decred:master Aug 23, 2024
5 checks passed
buck54321 added a commit to buck54321/dcrdex that referenced this pull request Aug 23, 2024
* filter out injected non-existent language

* npm audit fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants