Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zec: fix zcash multisplit #2931

Merged
merged 3 commits into from
Aug 26, 2024
Merged

zec: fix zcash multisplit #2931

merged 3 commits into from
Aug 26, 2024

Conversation

buck54321
Copy link
Member

@buck54321 buck54321 commented Aug 25, 2024

  • Refactor zcash multi-split. It wasn't working well or considering shielded funds
  • Fix Zcash withdraw address sent to cex. The unified address wasn't being parsed to a transparent.
  • Add ZEC-BTC market on the testbinance server
  • 0-conf transparent outputs are now immature for the purposes of split-order funding and e.g. simple sends. This is because orchard outputs require 1 conf, and we use z_sendmany which is ambigious as to where it will get funds from. Calling z_sendmany with 0 sometimes seems to throw errors, even if there is enough transparent funding.

I'll have a ZEC-USDT market up on the mainnet testing server in the morning. There's is a matching market on binance.us that bots can arb against. We can't arb zec on binance global until we implement the new exchange addresses.

@buck54321 buck54321 merged commit 887aa1b into decred:master Aug 26, 2024
5 checks passed
buck54321 added a commit to buck54321/dcrdex that referenced this pull request Aug 26, 2024
* fix zcash multisplit

* bump rpc version

* don't use btc.GetTransactionResult
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants