Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xmrswap: Remove C deps for signature encryption and dleq #2936

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

xmrswap: Remove C deps for signature encryption and dleq #2936

wants to merge 9 commits into from

Conversation

martonp
Copy link
Contributor

@martonp martonp commented Aug 28, 2024

Adds functions for encrypting / decrypting Schnorr signatures, and uses the athanorlabs/go-dleq library for discrete log equivalence.

@JoeGruffins
internal: Add libsecp256k1 c library.
ba9a320 
Add a c library that has some primitive cryptographic functions needed
for working with adaptor signatures.
@davecgh
Copy link
Member

davecgh commented Aug 28, 2024

Glad to see this! I did notice the dependency has various inefficiencies looking through it, but given that it won't be used in any type of hot paths, that is unlikely to matter much.

JoeGruffins
JoeGruffins approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow.

closes #2918

internal/cmd/xmrswap/main.go Outdated Show resolved Hide resolved
davecgh
davecgh reviewed Aug 28, 2024
View reviewed changes
dex/testing/loadbot/go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@JoeGruffins JoeGruffins mentioned this pull request Aug 28, 2024
Open
@xorzero777 @JoeGruffins
harness,doc: first commit
9001625
@xorzero777 @JoeGruffins
harness,docs: add new function - alpha_get_transactions_details
8960e94 
	get transaction development details from monerod
	including tx lock time; which is different from
	'locked'/'unlocked' which refer to when a tx
	has 10 confirmations. Tx locktime can be any
	number of blocks in the future.
@xorzero777 @JoeGruffins
harness: update per @JoeGruffins suggestions
60550d9 
	- Rename monero_functions.inc -> monero_functions
	- Tidy extra whitespace at eol for harness.sh &
	  monero_functions.
@xorzero777 @JoeGruffins
harness: Add a new wallet-less monero-wallet-rpc server instance
6ccec62 
	New monero-wallet-rpc server with no attached wallet. This is
 	for programmatically creating/generating and using a new wallet.

	The wallet will be generated in "own" dir but can be named what-
	ever you need: "alice", "Bob", etc.
davecgh
davecgh reviewed Aug 28, 2024
View reviewed changes
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
davecgh
davecgh reviewed Aug 28, 2024
View reviewed changes
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
@martonp martonp force-pushed the removeCDeps branch 2 times, most recently from a14385a to b16275a Compare September 1, 2024 09:19
@martonp
Copy link
Contributor Author

martonp commented Sep 1, 2024

@davecgh Thanks for the review!

@martonp martonp marked this pull request as ready for review September 1, 2024 09:27
davecgh
davecgh reviewed Sep 1, 2024
View reviewed changes
client/cmd/bisonw-desktop/go.mod Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
@martonp martonp force-pushed the removeCDeps branch 2 times, most recently from 1d0b008 to c0e9f55 Compare September 2, 2024 18:48
@martonp
Copy link
Contributor Author

martonp commented Sep 2, 2024

@JoeGruffins since these adaptor signatures use schnorr signatures rather than ecdsa as was in the C library, I've updated the tx scripts to use OP_CHECKSIGALT instead of OP_CHECKMULTISIG.

davecgh
davecgh reviewed Sep 2, 2024
View reviewed changes
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
davecgh
davecgh reviewed Sep 3, 2024
View reviewed changes
internal/adaptorsigs/adaptor_test.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
davecgh
davecgh reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@davecgh davecgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't looked at the DLEQ dep for correctness, but aside from the last nit in my most recent comment, the adaptor sig code looks accurate and reasonably efficient.

internal/adaptorsigs/dcr/dcr.go

import "github.com/decred/dcrd/txscript/v4"

func LockRefundTxScript(kal, kaf []byte, locktime int64) ([]byte, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since probably nothing other than the internal code will use it, I'm sure you guys probably aren't worried about it, but I'd point out that with no function comment and variables named kal and kaf, it's pretty unclear what they are here without looking at the code to determine they're Schnorr sigs over secp256k1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @JoeGruffins will do some refactor regarding variable names throughout after this one is merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

@martonp
Copy link
Contributor Author

martonp commented Sep 3, 2024

I haven't looked at the DLEQ dep for correctness, but aside from the last nit in my most recent comment, the adaptor sig code looks accurate and reasonably efficient.

OK thanks for the reviews! I think DLEQ dep will have to be audited before we release anything, but I think it is fine for this POC currently.

@davecgh
Copy link
Member

davecgh commented Sep 5, 2024

I followed up a bit on this comment, but it's resolved, so I figured I'd post a link to it here so it doesn't get missed.

davecgh
davecgh reviewed Sep 7, 2024
View reviewed changes
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
internal/adaptorsigs/adaptor.go Outdated Show resolved Hide resolved
@JoeGruffins
Copy link
Member

@martonp is on vacay, we'll pick up when they're back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dev-warrior777 dev-warrior777 dev-warrior777 left review comments

@JoeGruffins JoeGruffins JoeGruffins approved these changes

@davecgh davecgh davecgh left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@martonp @davecgh @JoeGruffins @dev-warrior777 @xorzero777