Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/webserver: Update static chinese translations #3071

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dev-warrior777
Copy link
Contributor

More correct static `zh_CN` translations `jsintl.go`

	More correct tsatic chinese translations
@dev-warrior777 dev-warrior777 marked this pull request as draft November 12, 2024 11:33
@dev-warrior777 dev-warrior777 marked this pull request as ready for review November 13, 2024 19:30
@JoeGruffins
Copy link
Member

Sorry I didn't look at this before, I dont know chinese... does this conflict with #3098 and do those look right?

@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Nov 27, 2024

Sorry I didn't look at this before, I dont know chinese... does this conflict with #3098 and do those look right?

They may conflict with this PR as a few are new and modified translations for jsintl.go

These I got from toothemoon; who is Chinese and kindly updated what we had. They are some we did not have + some he thought looked strange to a Chinese reader. These can be verified by another Chinese reader/dev and can probably be merged.
However there are a load (300+) of Chinese translations need to be done for MM, Bonds & other categories that I gave toothemoon a while back that he has not got time to do at the moment so any Chinese dev especially from China could be given the Translations worksheet I generated:

zh-CN.json

"You can ignore all the fields except the last two:"

  • "english": "<the english to be translated>"
    
  • "translation": "<your translation goes here>"
    

These can then be updated as shown in the context field i.e. notifications sent from core and html under client/webserver/src

@decredclub
Copy link

ok ,I just need to submit the json file, right? @dev-warrior777

@decredclub
Copy link

zh-CN.json
@dev-warrior777 The chinese translation has been completed and proofread, please check

@dev-warrior777
Copy link
Contributor Author

@decredclub .. so sorry late reply .. and thanks very much.

Yes I can work with the new file zh-CN.json you have kindly submitted. I will check a few translations with a Chinese Malaysian friend of mine. Then I will update the code using this PR #3071.

I agree that it will be great for Chinese people to use easily the app with correct translations.

@dev-warrior777 dev-warrior777 marked this pull request as draft December 5, 2024 15:32
@dev-warrior777
Copy link
Contributor Author

Back as a draft so that we can integrate the above new translations from the zh-CN.json file above. Have also sent to Reuben to have a look.

@dev-warrior777
Copy link
Contributor Author

The chinese translation has been completed and proofread, please check.

  1.  "english": "postbond request error (will retry): %v (%T)",
     "translation": "postbond 请求错误(将重试):%v (%T)"
    

Change to:
"error posting bond (will retry): %v (%T)"

  1.  "english": "Are you sure you want to remove the config for the {{ baseSymbol }}-{{ quoteSymbol }}  market on {{ host }}?",
     "translation": "您确定要移除 {{ host }} 上 {{ baseSymbol }}-{{ quoteSymbol }} 市场的配置吗?"
    

Change to:
"Are you sure you want to remove the configuration for the"

It means something like:
do you want to change the configuration for the DCR-BTC market on dex.decred.org:7232

@dev-warrior777
Copy link
Contributor Author

dev-warrior777 commented Dec 6, 2024

I sent the translations to 3 Chinese crypto guys and they all said they could understand > 90% of the translations easily. With the 2 changes above can be better - thanks!

@decredclub
Copy link

You're welcome. Hope this helps.

@dev-warrior777 dev-warrior777 marked this pull request as ready for review December 22, 2024 15:16
@dev-warrior777
Copy link
Contributor Author

@decredclub can you dm me on matrix or tg please

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants