deprecate unused dcrstakepool datadir config option #507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeGruffins
approved these changes
Aug 25, 2019
jholdstock
requested changes
Aug 26, 2019
There was a problem hiding this comment.
Nice catch @itswisdomagain. This is a good one to include in the release. We can remove this line from the test harness as well:
Line 148 in 72c1f98
jholdstock
approved these changes
Aug 28, 2019
jholdstock
added a commit
to jholdstock/dcrstakepool
that referenced
this pull request
Aug 28, 2019
dajohi
approved these changes
Aug 28, 2019
UferePease
pushed a commit
to UferePease/dcrstakepool
that referenced
this pull request
Sep 2, 2019
* deprecate unused dcrstakepool datadir config option * remove datadir config setting from test harness
girino
added a commit
to girino/dcrstakepool
that referenced
this pull request
Sep 7, 2019
* commit 'a94b6966190e4c5e69af571fca030460c64b43f6': deprecate unused dcrstakepool datadir config option (decred#507)
jyap808
pushed a commit
to ubiq/dcrstakepool
that referenced
this pull request
Dec 16, 2019
* deprecate unused dcrstakepool datadir config option * remove datadir config setting from test harness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After reading #502 (comment), noticed there is a
datadiroption present in dcrstakepool config that should not be present if data is not being stored by dcrstakepool. This PR deprecates that config option.