Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

comments: add Comments Plugin #2724

Merged
merged 54 commits into from
Mar 30, 2022
Merged

comments: add Comments Plugin #2724

merged 54 commits into from
Mar 30, 2022

Conversation

victorgcramos
Copy link
Member

@victorgcramos victorgcramos commented Feb 15, 2022 •
edited
Loading

This PR adds the Comments plugin into our new architecture.

Includes:

  • Comments, count, policy, timestamps and votes slices
  • Comment Card, Comments List and Comments UI
  • Comments filtering UI
  • Flat mode and thread mode
  • User vote highlighting
  • Comments censoring UI

Ps: new/edit comments, censoring and comments voting weren't implemented yet.

UI Changes

image

@victorgcramos victorgcramos mentioned this pull request Feb 15, 2022
Merged
5 tasks
@victorgcramos

This comment was marked as duplicate.

Sign in to view
@victorgcramos
comments: add comments plugin
803b903
@victorgcramos
comments: add record comments
69311d7
@victorgcramos
wip: comments count
6e509b6
@victorgcramos
refactor(comments): ui, tests, api and naming
74e4e13
@victorgcramos
chore(comments): comments slice naming
253b3ea
@victorgcramos
feat(comments): add comments count
be65a36
@victorgcramos
test(comments): add count tests
9b58d59
@victorgcramos
feat(comments): add comments policy
a8e76cd
@victorgcramos
wip: add comments timestamps
98a4e41
@victorgcramos
feat(comments): add timestamps download
c442026
@victorgcramos
test(comments): add timestamps tests
253e50c
@victorgcramos
fix(comments): code cleanup
434dddc
@victorgcramos
feat(comments): add user comments votes
8cd972e
@victorgcramos
fix(comments): export hooks correctly
3b1eef5
@victorgcramos
refactor(comments): move plugin executable to dev
d880c37
@victorgcramos
fix(comments): remove initialFetch from hooks
5ef7263
@victorgcramos
refactor(comments): move index.html to dev
2dc11d9
@victorgcramos
refactor(comments): use correct package exports
edee3de
@victorgcramos
style: prettify + remove unused stuff
00ef938
@victorgcramos
style: prettify
97530ec
@victorgcramos
feat(comments): add comments ui skeleton
cb99ce8
@victorgcramos
feat(comments): improve comments list ui
516794c
@victorgcramos
feat: add comments thread
fe5caea
@victorgcramos
feat: sort comments
4d8fa6a
@victorgcramos
chore: comments prop types
c426011
@victorgcramos
fix: improve filter styles
2432d33
@victorgcramos
feat: thread comments style improvements
a2f6817
@victorgcramos
fix: style adjustments
0e29239
@victorgcramos victorgcramos changed the title [WIP] comments: add Comments Plugin comments: add Comments Plugin Mar 7, 2022
@victorgcramos victorgcramos marked this pull request as ready for review March 7, 2022 17:31
tiagoalvesdulce
tiagoalvesdulce requested changes Mar 11, 2022
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. I left a few inline comments.

plugins-structure/packages/comments/src/comments/comments/commentsSlice.js Outdated Show resolved Hide resolved
plugins-structure/packages/comments/src/comments/count/useCount.js Outdated Show resolved Hide resolved
plugins-structure/packages/comments/src/comments/count/useCount.js Outdated Show resolved Hide resolved
plugins-structure/packages/comments/src/comments/timestamps/useTimestamps.js Outdated Show resolved Hide resolved
plugins-structure/packages/comments/src/comments/votes/votesSlice.js Outdated Show resolved Hide resolved
plugins-structure/packages/comments/src/ui/CommentCard/CommentVotes.js Outdated Show resolved Hide resolved
plugins-structure/packages/comments/src/ui/CommentCard/CommentVotes.js Show resolved Hide resolved
plugins-structure/packages/comments/src/ui/Comments/utils.js Outdated Show resolved Hide resolved
plugins-structure/packages/comments/src/ui/Comments/utils.js Outdated Show resolved Hide resolved
plugins-structure/packages/comments/src/ui/Comments/utils.js Outdated Show resolved Hide resolved
tiagoalvesdulce
tiagoalvesdulce approved these changes Mar 28, 2022
View reviewed changes
Copy link
Member

@tiagoalvesdulce tiagoalvesdulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiagoalvesdulce tiagoalvesdulce merged commit cdf48e0 into decred:master Mar 30, 2022
@victorgcramos victorgcramos deleted the comments branch April 28, 2022 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagoalvesdulce tiagoalvesdulce tiagoalvesdulce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorgcramos @tiagoalvesdulce