Replaces Travis with Github Action #465
Conversation
| name: Go lint | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
We don't use the push entry here, but rather protect the repository against direct pushes to master (which should be renamed to main :) and only allow merges when the tests pass.
This avoids running an unnecessary lint when you merge.
There was a problem hiding this comment.
Maybe redundant in some cases, but it doesn't hurt. I feel safer having a second check :)
.github/workflows/go_lint.yml
Outdated
| run: make lint | ||
|
|
||
| - name: Vet | ||
| run: make vet |
| name: Go test | ||
|
|
||
| on: | ||
| push: |
There was a problem hiding this comment.
same as above - you can remove push if the repo is configured accordingly.
.github/workflows/go_tests.yml
Outdated
| steps: | ||
| - uses: shogo82148/actions-goveralls@v1 | ||
| with: | ||
| parallel-finished: true |
| # Coding style static check. | ||
| @go install honnef.co/go/tools/cmd/staticcheck@latest | ||
| @go mod tidy | ||
| #staticcheck `go list ./...` |
There was a problem hiding this comment.
Do you want to put the staticcheck in its own target? That would make more sense, IMO.
There was a problem hiding this comment.
I prefer having one target that gathers all vetting scripts. Except if there is a case where we need to launch staticcheck but not the other linting tools.
Makefile
Outdated
| # target to run all the possible checks; it's a good habit to run it before | ||
| # pushing code | ||
| check: lint vet | ||
| go test ./... |
|
Kudos, SonarCloud Quality Gate passed! |
gofmtandgo mod tidystaticcheckis commented out because there are a lot to fix