Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hub blacklist is not thread safe #1747

Closed
2 of 6 tasks
MariemBaccari opened this issue Feb 20, 2024 · 0 comments · Fixed by #1754
Closed
2 of 6 tasks

Hub blacklist is not thread safe #1747

MariemBaccari opened this issue Feb 20, 2024 · 0 comments · Fixed by #1754
Assignees
Labels
be1-go good first issue Good for newcomers

Comments

@MariemBaccari
Copy link
Contributor

Description (Actual behavior)

The hub's blacklist is a simple array of strings which is not thread safe since we implemented the fine grain locking of the hub as opposed to locking the entire hub at every step.

Expected behavior

The blacklist should be implemented as a thread safe structure.

Front-ends:
  • Fe1-Web (please include browser's names & version)
  • Fe2-Android (please specify if phone or emulation, and Android version)
  • Not applicable
Back-ends:
  • Be1-Go
  • Be2-Scala
  • Not applicable

Impact

This can cause concurrency issues.

Possible root cause

In the Hub struct, blacklist is implemented as []string. We should use a thread safe structure instead and make the required changes in the parts of the code that use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
be1-go good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants