Work fe1 ljankoschek linked org UI #1834
Conversation
Pull reviewers statsStats of the last 30 days for popstellar:
|
|
🟠 There seems to be some formatting issues that must be applied from PR #1835 first. |
|
🟠 There seems to be some formatting issues that must be applied from PR #1835 first. |
1 similar comment
|
🟠 There seems to be some formatting issues that must be applied from PR #1835 first. |
|
🟠 There seems to be some formatting issues that must be applied from PR #1835 first. |
|
🟠 There seems to be some formatting issues that must be applied from PR #1835 first. |
1 similar comment
|
🟠 There seems to be some formatting issues that must be applied from PR #1835 first. |
…koschek-LinkedOrgUI Fixes by auto-format action
|
Please retry analysis of this Pull-Request directly on SonarCloud |
|
fe1-web/src/features/linked-organizations/components/AddLinkedOrganizationButton.tsx
Outdated
Show resolved
Hide resolved
fe1-web/src/features/linked-organizations/components/AddLinkedOrganizationButton.tsx
Outdated
Show resolved
Hide resolved
fe1-web/src/features/linked-organizations/components/AddLinkedOrganizationModal.tsx
Outdated
Show resolved
Hide resolved
fe1-web/src/features/linked-organizations/components/AddLinkedOrganizationModal.tsx
Outdated
Show resolved
Hide resolved
fe1-web/src/features/linked-organizations/components/AddLinkedOrganizationModal.tsx
Outdated
Show resolved
Hide resolved
fe1-web/src/features/linked-organizations/reducer/__tests__/LinkedOrganizationsReducer.test.ts
Outdated
Show resolved
Hide resolved
fe1-web/src/features/linked-organizations/screens/LinkedOrganizationsScreen.tsx
Outdated
Show resolved
Hide resolved
| @@ -305,7 +311,7 @@ namespace STRINGS { | |||
| 'The Roll Call is currently open and you as the organizer should start adding attendees by scanning their PoP tokens.'; | |||
| export const roll_call_open_attendee = | |||
| 'The Roll Call is currently open and you as an attendee should let the organizer scan your PoP token encoded in the QR Code below.'; | |||
| export const roll_call_qrcode_text = 'Scan to add attendee'; | |||
| export const roll_call_qrcode_text = 'Scan to\nadd\nattendee'; | |||
There was a problem hiding this comment.
Are the newlines necessary? Did the automatic text wrapping break?
There was a problem hiding this comment.
For me it didn't work here in qr code overlay
There was a problem hiding this comment.
Oh okay this is not good 😅 But I guess this is a good fix for now
| "contentEncoding": "hex", | ||
| "pattern": "^[0-9a-fA-F]{64}$", | ||
| "$comment": "A 32 bytes array encoded in hexadecimal" |
There was a problem hiding this comment.
Not that you need to change anything here, just curious: Why did you chose to go with hex instead of base64?
There was a problem hiding this comment.
Honestly, when we discussed the data authentication protocol we just described to use either base64 or hex and the backend guys started to implement it with hex..
|
|
|
|
|
UI Screens for the Federation Protocol with Tests. Added QRCode data structure and Validator.