Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE2] add peers back and send empty heartbeat #1891

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

DanielTavaresA
Copy link
Collaborator

Server should share peers to client again, and client should handle connection.

Server should now only send empty heartbeat to keep the connection alive. Spread of messages is handled by Gossip

@DanielTavaresA DanielTavaresA requested a review from a team as a code owner May 29, 2024 14:11
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
10
▀▀
4d 21h 51m
23
onsriahi14
🥈
6
1d 23h 8m
10
pierluca
🥉
5
6d 22h 1m
8
matteosz
5
4d 1h 36m
22
arnauds5
4
7d 5h 54m
12
simone-kalbermatter
4
1d 14h 46m
0
quadcopterman
4
5d 19h 9m
1
Tyratox
2
27d 19h 54m
▀▀▀
48
▀▀▀
t1b00
2
6d 6h 52m
4
osm-alt
2
6d 22h 53m
12
ljankoschek
2
18m
0
DanielTavaresA
2
2d 10h 22m
8
Kaz-ookid
2
7d 15h 16m
7
1florentin
1
8d 13h 49m
6
sgueissa
1
6d 11h 44m
1
emonnin-epfl
1
51m
1
⚡️ Pull request stats

@DanielTavaresA DanielTavaresA linked an issue May 29, 2024 that may be closed by this pull request
Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 29, 2024

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented May 29, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@K1li4nL K1li4nL added this pull request to the merge queue Jun 3, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 3, 2024
@DanielTavaresA DanielTavaresA added this pull request to the merge queue Jun 3, 2024
Merged via the queue into master with commit 36cb6ef Jun 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back hearbeats and sharing peers
2 participants