Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[be1] reorganize files #1901

Merged
merged 19 commits into from
Jun 2, 2024
Merged

[be1] reorganize files #1901

merged 19 commits into from
Jun 2, 2024

Conversation

sgueissa
Copy link
Collaborator

@sgueissa sgueissa commented Jun 2, 2024

It is the first PR of cleaning and other PRs will come. Next PR will be creating a global error type and removing the *answer.Error return type.

  1. Moved all the old backend inside the directory old
  2. Moved all the files inside internal but cli
  3. Break the handler package in Query, Answer and Channel package to prepare for the incoming ref injection and top to bottom building in a future PR
  4. Update the doc

Copy link

github-actions bot commented Jun 2, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
10
▀▀▀
4d 20h 56m
12
▀▀▀
simone-kalbermatter
🥈
4
8h 40m
0
onsriahi14
🥉
4
1d 23h 8m
4
matteosz
3
4d 40m
5
pierluca
2
3d 11h 3m
1
arnauds5
2
5d 15h 3m
▀▀
0
DanielTavaresA
2
2d 10h 22m
8
▀▀
quadcopterman
2
6d 13h 46m
▀▀
1
Tyratox
1
44m
0
sgueissa
1
6d 11h 44m
▀▀
1
osm-alt
1
25m
0
emonnin-epfl
1
51m
1
Kaz-ookid
1
1d 2h 1m
5
⚡️ Pull request stats

@K1li4nL K1li4nL added the be1-go label Jun 2, 2024
@sgueissa sgueissa marked this pull request as ready for review June 2, 2024 17:01
@sgueissa sgueissa requested a review from a team as a code owner June 2, 2024 17:01
@sgueissa sgueissa self-assigned this Jun 2, 2024
Copy link
Contributor

@emonnin-epfl emonnin-epfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mocks should be renamed mock since all packages are singular (expect types which will be removed later). You changed the high and low packages as we discussed on WhatsApp which is great and same thing for renaming fake_socket to socket.

Overall nice job

be1-go/cli/cli.go Outdated Show resolved Hide resolved
emonnin-epfl
emonnin-epfl previously approved these changes Jun 2, 2024
Copy link

sonarcloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blind approval

Copy link

sonarcloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 2, 2024

Quality Gate Failed Quality Gate failed for 'PoP - Be1-Go'

Failed conditions
33.3% Coverage on New Code (required ≥ 65%)
1 New Critical Issues (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

sonarcloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sgueissa sgueissa added this pull request to the merge queue Jun 2, 2024
Merged via the queue into master with commit 1969117 Jun 2, 2024
17 of 18 checks passed
@sgueissa sgueissa deleted the work-be1-stuart-reorganize-files branch June 2, 2024 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants