-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[be1] reorganize files #1901
[be1] reorganize files #1901
Conversation
Pull reviewers statsStats of the last 30 days for popstellar:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think mocks should be renamed mock since all packages are singular (expect types which will be removed later). You changed the high and low packages as we discussed on WhatsApp which is great and same thing for renaming fake_socket to socket.
Overall nice job
Quality Gate passed for 'PoP - PoPCHA-Web-Client'Issues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blind approval
Quality Gate passed for 'PoP - Be2-Scala'Issues Measures |
Quality Gate failed for 'PoP - Be1-Go'Failed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Quality Gate passed for 'PoP - Fe1-Web'Issues Measures |
Quality Gate passed for 'PoP - Fe2-Android'Issues Measures |
It is the first PR of cleaning and other PRs will come. Next PR will be creating a global error type and removing the *answer.Error return type.