Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work fe1 ljankoschek linked org authentication additions and data exchange #1913

Merged
merged 12 commits into from
Jun 30, 2024
Merged

Work fe1 ljankoschek linked org authentication additions and data exchange #1913

merged 12 commits into from
Jun 30, 2024

Conversation

ljankoschek
Copy link
Contributor

@ljankoschek ljankoschek commented Jun 6, 2024 •
edited
Loading

Make changes for more consistency with fe1, implement federation result message and add Data Exchange

@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 6, 2024

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇		 17
▀▀▀▀		 3d 23h 9m
▀		 20
▀▀▀
matteosz
🥈		 5
▀		 1d 7h 45m
 4
▀
simone-kalbermatter
🥉		 4
▀		 8h 40m
 0
onsriahi14
 4
▀		 1d 10h 51m
 5
▀
emonnin-epfl
 3
▀		 8h 20m
 8
▀
DanielTavaresA
 3
▀		 2d 19h 23m
▀		 10
▀▀
pierluca
 2
 3d 11h 3m
▀		 1
MariemBaccari
 2
 22h 39m
 6
▀
Tyratox
 1
 44m
 0
arnauds5
 1
 10d 19h 13m
▀▀▀		 0
sgueissa
 1
 6d 11h 44m
▀▀		 1
osm-alt
 1
 25m
 0
quadcopterman
 1
 4d 2h 40m
▀		 0
Kaz-ookid
 1
 1d 2h 1m
 5
▀
⚡️ Pull request stats

@ljankoschek ljankoschek changed the title Work fe1 ljankoschek linked org auth fix Work fe1 ljankoschek linked org auth fixes Jun 11, 2024
@ljankoschek ljankoschek changed the title Work fe1 ljankoschek linked org auth fixes Work fe1 ljankoschek linked org authentication additions Jun 11, 2024
@ljankoschek ljankoschek self-assigned this Jun 11, 2024
@ljankoschek ljankoschek marked this pull request as ready for review June 25, 2024 14:05
@ljankoschek ljankoschek requested a review from a team as a code owner June 25, 2024 14:05
1florentin
1florentin previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@1florentin 1florentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ljankoschek ljankoschek changed the title Work fe1 ljankoschek linked org authentication additions Work fe1 ljankoschek linked org authentication additions and data exchange Jun 28, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jun 28, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

4xiom5
4xiom5 approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@4xiom5 4xiom5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meets specs

K1li4nL
K1li4nL approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blind approval

@K1li4nL K1li4nL added this pull request to the merge queue Jun 30, 2024
Merged via the queue into master with commit 14b1cdd Jun 30, 2024
17 checks passed
@K1li4nL K1li4nL deleted the work-fe1-ljankoschek-LinkedOrgAuthFix branch June 30, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@K1li4nL K1li4nL K1li4nL approved these changes

@4xiom5 4xiom5 4xiom5 approved these changes

@1florentin 1florentin Awaiting requested review from 1florentin

Assignees

@ljankoschek ljankoschek

Labels
fe1-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ljankoschek @4xiom5 @1florentin @K1li4nL