[BE1] Upgrade gossip rumor with vector clock #1938

sgueissa · 2024-06-14T22:05:59Z

In this PR we did:

Rumor Push protocol with vector clock
Buffer inside Rumor handler to handle cases where a newer rumor is arriving few second before an older rumor
Rumor Pull protocol with vector clock
Fix order of the answer to catchup query

…e rumor timestamps

…e sender function

github-actions · 2024-06-14T22:06:14Z

Pull reviewers stats

Stats of the last 30 days for popstellar:

	User	Total reviews	Time to review	Total comments
	K1li4nL 🥇	20 ▀▀▀▀	1d 19h 44m ▀	10 ▀▀
	arnauds5 🥈	6 ▀	18h 5m	4 ▀
	emonnin-epfl 🥉	5 ▀	8h 20m	9 ▀▀
	onsriahi14	4 ▀	1d 1h 53m ▀	4 ▀
	simone-kalbermatter	3 ▀	1h 47m	0
	matteosz	3 ▀	14h 5m	3 ▀
	pierluca	2	3d 11h 3m ▀▀	1
	sgueissa	2	1d 12h 28m ▀	4 ▀
	MariemBaccari	2	22h 39m	6 ▀
	DanielTavaresA	2	9d 21h 46m ▀▀▀▀▀	2
^{⚡️ Pull request stats}

…RumorStateAnswer

sonarcloud · 2024-06-26T19:05:52Z

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-06-26T19:08:24Z

Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarcloud · 2024-06-26T19:08:44Z

Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
68.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

emonnin-epfl

LVGTM!

sgueissa · 2024-06-26T19:11:22Z

LVGTM!

YOU TOO!!!

sonarcloud · 2024-06-26T19:14:00Z

Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

K1li4nL

Blind approval

sgueissa and others added 15 commits June 14, 2024 16:53

Add timestamp to rumor message

83f0e73

Add rumorstate message

06d2339

Add const for rumorstate message inside query

6db3f48

Add function to answer to rumor state message

8a0f78a

update ChecRumor and GetAndIncrementMyRumor by taking into account th…

9fef806

…e rumor timestamps

Add rumor timestamp type

1845fea

fix import cycle

6acfc89

replace mape[string]int by RumorTimestamp type and implement rumorSat…

977f2b4

…e sender function

specify delay for rumorState message

0f4b85c

fix timestamp

3258bcb

upgrade buffer

49cf007

upgrade rumor handling

a5e23d7

delete sort function of rumor

9a1cfd0

fixe timestamp

b79a179

fix sorting

aa7a8df

sgueissa added the be1-go label Jun 14, 2024

sgueissa assigned sgueissa and emonnin-epfl Jun 14, 2024

sgueissa and others added 11 commits June 15, 2024 11:36

Refactor state queries

40442dc

Handler rumor state answer without test

4951a10

Push working

c8a5de5

add rumorState handling

f08aa7d

fix getRumorTimestampHelper() by decreasing the server rumorID by 1

858d633

update timestamp when increasing rumorID

8a1f3a6

fix wrong rumor_state struct

9932cc7

fix deadlock when getting all rumors

17e0866

fix error where in construction rumor was send in rumor state answer

6e1e527

fix wrong answer to rumorstate

189cc80

add rumor state to queries

df35f3f

sgueissa and others added 16 commits June 25, 2024 00:27

do not propagate to sender of rumorstate answer

12ad440

inverse order when get all message from a channel

163be84

marshal unprocessed messages before storing

21193b8

add 2 more configs

ed7cb9b

fix getALlMessagesFromChannel test

69f2145

fix test

2fce406

add tests to rumor queries

2ba8475

add tests for rumortate, rumorstate answer, rumor answer

b737c4e

change GetAllRumors to GetAllRumorParams

7920204

check unused errors

be39a15

fix linter

acb4800

remove isEqual check in rumorstate handler

4d2089b

the rumor buffer is now a buffer of rumor params, add tests to Handle…

8582cc5

…RumorStateAnswer

remove newRumor sqlite function

4821d50

remove prints in buffer.go

1806e9d

put non important logs at debug level

5ba62b2

sgueissa marked this pull request as ready for review June 26, 2024 19:09

sgueissa requested a review from a team as a code owner June 26, 2024 19:09

emonnin-epfl approved these changes Jun 26, 2024

View reviewed changes

sgueissa enabled auto-merge June 26, 2024 19:51

K1li4nL approved these changes Jun 26, 2024

View reviewed changes

sgueissa added this pull request to the merge queue Jun 26, 2024

Merged via the queue into master with commit 4945cad Jun 26, 2024
17 checks passed

sgueissa deleted the work-be1-stuart-etienne-rumor-with-vector-clock branch June 26, 2024 20:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BE1] Upgrade gossip rumor with vector clock #1938

[BE1] Upgrade gossip rumor with vector clock #1938

sgueissa commented Jun 14, 2024 •

edited

Loading

github-actions bot commented Jun 14, 2024

sonarcloud bot commented Jun 26, 2024

sonarcloud bot commented Jun 26, 2024

sonarcloud bot commented Jun 26, 2024

emonnin-epfl left a comment

sgueissa commented Jun 26, 2024

sonarcloud bot commented Jun 26, 2024

K1li4nL left a comment

[BE1] Upgrade gossip rumor with vector clock #1938

[BE1] Upgrade gossip rumor with vector clock #1938

Conversation

sgueissa commented Jun 14, 2024 • edited Loading

github-actions bot commented Jun 14, 2024

Pull reviewers stats

sonarcloud bot commented Jun 26, 2024

Quality Gate passed for 'PoP - PoPCHA-Web-Client'

sonarcloud bot commented Jun 26, 2024

Quality Gate passed for 'PoP - Be2-Scala'

sonarcloud bot commented Jun 26, 2024

Quality Gate passed for 'PoP - Be1-Go'

emonnin-epfl left a comment

Choose a reason for hiding this comment

sgueissa commented Jun 26, 2024

sonarcloud bot commented Jun 26, 2024

Quality Gate passed for 'PoP - Fe2-Android'

K1li4nL left a comment

Choose a reason for hiding this comment

sgueissa commented Jun 14, 2024 •

edited

Loading