Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data input validation for OpenRollCall + constructor tests #1960

Merged
merged 1 commit into from
Jun 30, 2024

Conversation

Kaz-ookid
Copy link
Contributor

complete message data validation for OpenRollCall, addressing #1751

@Kaz-ookid Kaz-ookid self-assigned this Jun 27, 2024
@Kaz-ookid Kaz-ookid requested a review from a team as a code owner June 27, 2024 20:12
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
24
▀▀▀▀
1d 19h 44m
12
▀▀
arnauds5
🥈
7
4h 29m
4
matteosz
🥉
7
3d 16h 27m
21
▀▀▀
emonnin-epfl
6
8h 20m
8
sgueissa
3
7h 59m
5
quadcopterman
3
10d 7h 3m
▀▀▀
1
1florentin
2
10d 5h 50m
▀▀▀
0
MariemBaccari
2
22h 39m
6
simone-kalbermatter
2
5h 32m
0
onsriahi14
2
6d 4h 27m
▀▀
4
Kaz-ookid
1
3d 19h 13m
5
⚡️ Pull request stats

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link

sonarcloud bot commented Jun 27, 2024

Copy link
Contributor

@matteosz matteosz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@matteosz matteosz added this pull request to the merge queue Jun 30, 2024
Merged via the queue into master with commit 3c0b81e Jun 30, 2024
18 checks passed
@matteosz matteosz deleted the work-fe2-maxime-rollcall-data-validation branch June 30, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants