Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deegree WMS 1.3 does not return exception when mandatory version parameter is missing #1183

Closed
dstenger opened this issue Sep 23, 2021 · 4 comments · Fixed by #1218
Closed
Labels
bug error issue and bug (fix)

Comments

@dstenger
Copy link
Contributor

This occurs when a GetMap request is send:

A map is returned instead of an exception.
This is backed up by the specification (OGC® 06-042) as version is a mandatory parameter.

@dstenger dstenger added the bug error issue and bug (fix) label Sep 24, 2021
@dstenger
Copy link
Contributor Author

However, it is not 100% clear what exception type shall be thrown as deegree does not know what WMS version is requested.
Please also see: #1182 (comment)

@dstenger
Copy link
Contributor Author

dstenger commented Sep 24, 2021

We should be aware that some clients may omit the version parameter in a GetMap request.
So, a fix might break the compatibility of deegree with some clients.

Geoserver, for example, ignores a missing version.
https://maps1.geosolutionsgroup.com/geoserver/osm/wms?SERVICE=WMS&REQUEST=GetMap&FORMAT=image%2Fpng8&TRANSPARENT=true&LAYERS=osm&tiled=true&STYLES&WIDTH=256&HEIGHT=256&SRS=EPSG%3A3857&BBOX=1487158.8223163895%2C5165920.119625352%2C1526294.5807983999%2C5205055.878107362 is working as well

@dstenger
Copy link
Contributor Author

From TMC meeting 2021-09-24: We propose to add a configuration flag such as "strict-validation" that can enable the required behavior.

@dstenger
Copy link
Contributor Author

I posted this problem to the OSGeo-Standards mailing list and received an answer how GeoServer is handling this problem: https://lists.osgeo.org/pipermail/standards/2021-October/001283.html

GeoServer uses the same solution as proposed in #1183 (comment)

Also, the version number negotiation of GeoServer follows a logical pattern. A similar mechanism might be introduced to deegree as well.

lgoltz added a commit to lat-lon/deegree3 that referenced this issue Oct 14, 2021
…ecption is version param is missing (except GetCapabilities requests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant