Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance FeatureInspector with the context of the transaction, if available #1290

Conversation

stephanr
Copy link
Member

This PR extends the FeatureInspector in a backwards compatible way (default interface) to give the feature inspection, if available, more context information.

… a FeatureStoreTransaction

  (changes are backwards compatible, default interface extension)
@stephanr stephanr added the enhancement enhancement or improvement label Mar 11, 2022
@stephanr
Copy link
Member Author

@stephanr
Copy link
Member Author

Postponed because the actual change to use the new interface was pushed to another pr, but was supposed to be included in this one.

@@ -556,7 +560,7 @@ public List<String> performInsert( FeatureCollection fc, IDGenMode mode )
for ( FeatureInspector inspector : inspectors ) {
for ( Feature f : features ) {
// TODO cope with inspectors that return a different instance
inspector.inspect( f );
inspector.inspect( f, this );
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment #1290 (comment)

Postponed because the actual change to use the new interface was pushed to another pr, but was supposed to be included in this one.

After a new review, it turned out that all affected changes are already included.

@stephanr stephanr merged commit edc729f into deegree:master Apr 13, 2022
@tfr42 tfr42 added this to the 3.4.29 milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement enhancement or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants