Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix schema validation of console #1535

Merged

Conversation

stephanr
Copy link
Member

This PR changes the schema locations from fully qualified jar with inside location to only the location on the classpath (/META-INF/schemas/).

Fixes #1491

@stephanr stephanr added bug error issue and bug (fix) in progress console deegree administration console labels Jun 22, 2023
@stephanr stephanr self-assigned this Jun 22, 2023
@stephanr stephanr requested review from lgoltz and julianzz98 June 22, 2023 16:50
@stephanr
Copy link
Member Author

@lgoltz @julianzz98
This is labeled as in progress as i currently only tested this with a docker container.

@julianzz98
Copy link
Contributor

Thank you for the quick PR! I tested your changes locally by deploying the deegree webapp on a docker container and can confirm that the bug from #1491 is now fixed.

FeatureLayer:
Screenshot from 2023-06-22 21-50-14

GDALLayerStore:
Screenshot from 2023-06-22 22-11-27

Theme:
Screenshot from 2023-06-22 21-50-38

Additionally, I observed a really slightly longer duration of the validation process (~0,5 to 1 sec.), which can be ignored in my opinion. A test without the use of docker should perhaps still be carried out.

@tfr42 tfr42 removed the in progress label Jul 12, 2023
@copierrj copierrj merged commit 9f50140 into deegree:main Jul 12, 2023
@tfr42 tfr42 added this to the 3.5 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug error issue and bug (fix) console deegree administration console
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example templates in the deegree console invalid
4 participants