Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace String.replaceAll and String.replaceFirst with precompiled java.util.regex.Pattern to speed up String replacements #1691

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

stephanr
Copy link
Member

@stephanr stephanr commented Jun 5, 2024

This PR is a rebased version of #1639 which resolved the conflicts.
Original Text:

Proposal for replacing pattern compiles in degree for methods: String.replaceFirst and String.replaceAll

Closes #1639
Fixes #1633

References:

@stephanr stephanr added enhancement enhancement or improvement core deegree core modules labels Jun 5, 2024
@stephanr stephanr self-assigned this Jun 5, 2024
@tfr42
Copy link
Member

tfr42 commented Jun 5, 2024

@kad-vetteh Thanks for contributing to the OSGeo project deegree. Since this is your first code contribution we kindly ask you to read the deegree contribution guidelines and confirm to by sending an email to the deegree users mailing list. Thanks!

@stephanr stephanr added this to the 3.6 milestone Jun 5, 2024
@tfr42 tfr42 merged commit 2f848f6 into deegree:main Jun 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core deegree core modules enhancement enhancement or improvement
Projects
None yet
3 participants