Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new module deegree-core-test-logging, add test-logging dependencies and remove log4j2.properties in test modules #1704

Merged
merged 5 commits into from
Jun 7, 2024
Merged

Create new module deegree-core-test-logging, add test-logging dependencies and remove log4j2.properties in test modules #1704

merged 5 commits into from
Jun 7, 2024

Conversation

dstenger
Copy link
Contributor

@dstenger dstenger commented Jun 6, 2024 •
edited
Loading

This PR

  • adds new module deegree-core-testing-logging which includes logging dependencies and logging configuration
  • adds deegree-core-testing-logging in scope test to all modules which use logging in their tests
  • removes scope test from deegree-core-testing-logging in all deegree-tests modules
  • removes existing log4j2.properties from deegree-tests modules
  • removes existing log4j.properties from deegree-core-cs module
  • excludes log4j-to-slf4j from spring-boot-starter-batch

Fixes #1606.

@dstenger dstenger force-pushed the enableTestLogging-1606 branch from 73a0ec9 to 0edd93d Compare June 6, 2024 17:10
@dstenger dstenger marked this pull request as ready for review June 7, 2024 08:10
dstenger added 2 commits June 7, 2024 11:49
@dstenger
Exclude log4j-to-slf4j from spring-boot-starter-batch
3d027fe
@dstenger
Remove scope test from deegree-core-test-logging in deegree-tests mod…
6900d0e 
…ules and add dependency deegree-core-test-logging to two additonal deegree-tests modules
@stephanr
Copy link
Member

stephanr commented Jun 7, 2024

This will also remove the patch introduced in #1631

References:

@stephanr stephanr merged commit b735de0 into deegree:main Jun 7, 2024
1 check passed
@tfr42 tfr42 added enhancement enhancement or improvement core deegree core modules labels Jun 7, 2024
@tfr42 tfr42 added this to the 3.6 milestone Jun 7, 2024
@stephanr stephanr mentioned this pull request Jun 7, 2024
Draft
1 task
@lgoltz lgoltz deleted the enableTestLogging-1606 branch November 19, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanr stephanr stephanr approved these changes

Assignees
No one assigned
Labels
core deegree core modules enhancement enhancement or improvement
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.

Identify packages with tests executed without logger implementation and add logger implementation
3 participants
@dstenger @stephanr @tfr42