pulling latest changes from kubeflow/tf-operator to deepak-muley/tf-operator #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Change release process 2. Checking python tool to generate changelog 3. Fix v1.2.0 changlog
* 1322: Modified manifests to use all-in-one training-operator WIP
Actions taken:
- replaced tf-job-operator => training-operator
- replaced kubeflow-tfjobs- => kubeflow-training-
- moved crds for mxjobs, tgjobs, pytorchjobs and xgboostjobs from
config/crd/bases to manifests/base/ and prefixed them with crd_
Ref: #1322
Testing steps: To be added
Work in Progress
* 1322: synced up config/manager with manifests
Training operator was found to be working
<pre>
k -n kubeflow logs -f training-operator-694766989-pp2j4
I0812 21:43:24.739862 1 request.go:645] Throttling request took 1.048945631s, request: GET:https://172.19.0.1:443/apis/networking.k8s.io/v1?timeout=32s
2021-08-12T21:43:25.694Z INFO controller-runtime.metrics metrics server is starting to listen {"addr": ":8080"}
2021-08-12T21:43:25.790Z INFO setup starting manager
2021-08-12T21:43:25.790Z INFO controller-runtime.manager starting metrics server {"path": "/metrics"}
2021-08-12T21:43:25.790Z INFO controller-runtime.manager.controller.tf-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:25.790Z INFO controller-runtime.manager.controller.mxnet-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:25.791Z INFO controller-runtime.manager.controller.pytorchjob-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:25.791Z INFO controller-runtime.manager.controller.xgboostjob-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:26.289Z INFO controller-runtime.manager.controller.xgboostjob-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:26.294Z INFO controller-runtime.manager.controller.pytorchjob-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:26.589Z INFO controller-runtime.manager.controller.mxnet-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:26.688Z INFO controller-runtime.manager.controller.tf-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:26.889Z INFO controller-runtime.manager.controller.tf-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:26.889Z INFO controller-runtime.manager.controller.pytorchjob-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:26.890Z INFO controller-runtime.manager.controller.xgboostjob-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:26.890Z INFO controller-runtime.manager.controller.mxnet-operator Starting EventSource {"source": "kind source: /, Kind="}
2021-08-12T21:43:26.990Z INFO controller-runtime.manager.controller.xgboostjob-operator Starting Controller
2021-08-12T21:43:26.990Z INFO controller-runtime.manager.controller.tf-operator Starting Controller
2021-08-12T21:43:26.990Z INFO controller-runtime.manager.controller.tf-operator Starting workers {"worker count": 1}
2021-08-12T21:43:26.990Z INFO controller-runtime.manager.controller.pytorchjob-operator Starting Controller
2021-08-12T21:43:26.991Z INFO controller-runtime.manager.controller.xgboostjob-operator Starting workers {"worker count": 1}
2021-08-12T21:43:26.991Z INFO controller-runtime.manager.controller.pytorchjob-operator Starting workers {"worker count": 1}
2021-08-12T21:43:26.991Z INFO controller-runtime.manager.controller.mxnet-operator Starting Controller
2021-08-12T21:43:26.991Z INFO controller-runtime.manager.controller.mxnet-operator Starting workers {"worker count": 1}
</pre>
* 1322: incorporated review comments - added all resources in ClusterRole
* 1322: incorporated review comments
- now controller-gen generates the crds directly in manifests/base
instead of config/crd/bases
- updated setup-training-operator.sh to use manifests/overlays/standalone
* 1322: removed config/crd/bases as its now getting generated in manifests
* 1322: incorporated review comments related to using separate role files
* 1322: removed image name replacement
* Clean up manifests * Remove prometheus and manager folder * Update override image tag for kubeflow manifest * Delete leader election role * Remove non-exist tag in deployment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.