Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix release-drafter and pr-semantic-check #103

Merged
merged 4 commits into from
Jan 7, 2021

Conversation

deepcharles
Copy link
Owner

@deepcharles deepcharles commented Jan 7, 2021

  • The GH Action was falling because of some empty option.
  • Also the PR semantic check was not behaving as expected. Replaced by the associated Gh App.

@github-actions github-actions bot added the Type: CI Changes to CI configuration files and scripts label Jan 7, 2021
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #103 (639b968) into master (b2e7c62) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #103   +/-   ##
=======================================
  Coverage   86.68%   86.68%           
=======================================
  Files          41       41           
  Lines         954      954           
=======================================
  Hits          827      827           
  Misses        127      127           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2e7c62...639b968. Read the comment docs.

@deepcharles
Copy link
Owner Author

The gh action Lint PR has been removed, replace by the associate Github App.
It is simpler to use that way.

@deepcharles
Copy link
Owner Author

Two Gh actions are failling but they will be removed once thie PR is merged to main.

@deepcharles deepcharles changed the title ci: fix config for release-drafter gh action ci: fix release-drafter and pr-semantic-check Jan 7, 2021
@deepcharles deepcharles merged commit 306efb5 into master Jan 7, 2021
@deepcharles deepcharles deleted the ci/release-drafter-fix branch January 7, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: CI Changes to CI configuration files and scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant