Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added pulling from AWS #13

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Added pulling from AWS #13

merged 3 commits into from
Apr 19, 2023

Conversation

nissimofir
Copy link
Contributor

No description provided.

@nissimofir nissimofir self-assigned this Apr 18, 2023
@nissimofir nissimofir marked this pull request as ready for review April 19, 2023 07:45
yromanyshyn
yromanyshyn approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@yromanyshyn yromanyshyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not the fun of putting any other logic besides validation into validators, but I either do not see any other simple solution that does not require a lot of refactoring, so, let it be

@nissimofir nissimofir merged commit b20f16e into main Apr 19, 2023
@nissimofir nissimofir deleted the ofir/mon-1818-add-password-manager-for-postgres-redis branch April 19, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yromanyshyn yromanyshyn yromanyshyn approved these changes

Assignees

@nissimofir nissimofir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nissimofir @yromanyshyn