Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Cypress E2E #4

Merged
merged 13 commits into from
Apr 19, 2023
Merged

Fix Cypress E2E #4

merged 13 commits into from
Apr 19, 2023

Conversation

lironhamra
Copy link
Contributor

No description provided.

@ItayGabbay ItayGabbay marked this pull request as ready for review April 9, 2023 13:49
@gitguardian
Copy link

gitguardian bot commented Apr 9, 2023

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
6232305 Auth0 Keys 1001965 .development.env View secret
6232306 LaunchDarkly SDK Key 1001965 .development.env View secret
6232312 RSA Private Key 1001965 deploy/local_certs/CA/rootCA.key View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@ItayGabbay ItayGabbay marked this pull request as draft April 9, 2023 14:16
@ItayGabbay ItayGabbay marked this pull request as ready for review April 16, 2023 12:53
@lironhamra lironhamra requested a review from ItayGabbay April 19, 2023 07:24
@lironhamra lironhamra merged commit 3cd26d0 into main Apr 19, 2023
@lironhamra lironhamra deleted the fix-cypress-e2e branch April 19, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants