Merge pull request #1 from deepdik/feature/optimization

Optimize file reading by switching to stream-based comment filtering
deepdik · Nov 14, 2024 · 3e3bb37 · 3e3bb37
2 parents 3871374 + 6710f4a
commit 3e3bb37
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/showcases/src/test/java/org/example/ShowcaseCompilerTest.java b/showcases/src/test/java/org/example/ShowcaseCompilerTest.java
@@ -103,9 +103,12 @@ private static Set<Path> getShowcaseFilePaths(Path showcaseDirectory)
     public void processShowcaseFile() throws IOException
     {
         // Stripping comments required as parser will remove them
-        String pureGrammar = Files.readAllLines(showcasePath).stream()
-                .filter(l -> !l.stripLeading().startsWith("//"))
+        String pureGrammar;
+        try (Stream<String> lines = Files.lines(showcasePath)) {
+            pureGrammar = lines
+                .filter(line -> !line.stripLeading().startsWith("//"))
                 .collect(Collectors.joining("\n"));
+        }
 
         assumeFalse(pureGrammar.isEmpty());